[PATCH 4/4] ARM: dts: sun8i: add OTG function to Lichee Pi Zero

[Icenowy Zheng]

11.01.2017, 04:24, "Bin Liu" <b-liu at ti.com>:
> On Tue, Jan 03, 2017 at 11:25:34PM +0800, Icenowy Zheng wrote:
>>  Lichee Pi Zero features a USB OTG port.
>>
>>  Add support for it.
>>
>>  Note: in order to use the Host mode, the board must be powered via the
>>  +5V and GND pins.
>>
>>  Signed-off-by: Icenowy Zheng <icenowy at aosc.xyz>
>>  ---
>>   arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>>  diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts
>>  index 0099affc6ce3..3d9168cbaeca 100644
>>  --- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts
>>  +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero.dts
>>  @@ -71,3 +71,13 @@
>>           pinctrl-names = "default";
>>           status = "okay";
>>   };
>>  +
>>  +&usb_otg {
>>  + dr_mode = "otg";
>
> Why not set this default mode in dtsi instead?
>
> Regards,
> -Bin.

There's possibly boards which do not have OTG functions.

Even the official CDR design of V3s uses the USB controller to
connect a UVC webcam to make the design a dual-cam design
(V3s itself has a CSI).

>
>>  + status = "okay";
>>  +};
>>  +
>>  +&usbphy {
>>  + usb0_id_det-gpio = <&pio 5 6 GPIO_ACTIVE_HIGH>;
>>  + status = "okay";
>>  +};
>>  --
>>  2.11.0