[Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

[Dan Carpenter]

On Mon, Feb 27, 2017 at 07:25:30AM +0100, Julia Lawall wrote:
> 
> 
> On Sun, 26 Feb 2017, Scott Branden wrote:
> 
> >
> >
> > On 17-02-26 01:56 PM, Joe Perches wrote:
> > > On Sun, 2017-02-26 at 20:40 +0100, Julia Lawall wrote:
> > > > On Sun, 26 Feb 2017, Joe Perches wrote:
> > > > > On Sun, 2017-02-26 at 19:59 +0100, Julia Lawall wrote:
> > > > > > On Sun, 26 Feb 2017, Joe Perches wrot
> > > > > > > Mailing lists _should_ be copied on patch submissions.
> > > > > > The idea of outreachy is that it should be a place for people to get
> > > > > > started without too much criticism from the outside.  Originally, only
> > > > > > the
> > > > > > outreachy mailing list received patches.  But staging maintainers were
> > > > > > confused to have their drivers receiving patches that they had not
> > > > > > seen.
> > > > > > So we expanded it to maintainers.
> > > > >

It was mostly me being annoyed because outreachy reviews are not that
good frankly.  We just were just looking at outreachy code from 2013
where they "fixed" sparse endian notations by removing the endian
conversions.  It was so obviously wrong just from reading the changelog
before you even got to the patch itself...

> > > > > That also doesn't make much sense as patches
> > > > > should not be applied that have not reached
> > > > > a mailing list for review.
> > > > >
> > > > > As long as initial outreachy patches are not
> > > > > applied and are just for internal review by
> > > > > any outside person but the outreachy list and
> > > > > are not be applied by maintainers, then perhaps
> > > > > it's best if neither maintainers nor lists are
> > > > > cc'd on the patches.
> > > >
> > > > The patches are applied by Greg.  Greg suggested the policy of adding
> > > > maintainers but not including mailing lists.  I'll let him consider
> > > > whether the policy should be changed.
> > >
> > > Well, I will comment on patches sent to the kernel list.
> > >
> > > I'm not subscribed to outreachy and I don't want to be
> > > subscribed to that list either.
> > >
> > I would prefer this outreachy work uses their own mailing list and reviews
> > their patches first.  Then once they have everything sorted out they send out
> > the patch series to the proper maintainers/mailing lists. That way we're not
> > spammed with all these emails of people as they are learning how to format and
> > send out proper patches.
> 

Outreachy emails are not really worse than normal staging patches so
I don't mind the spam.  But it would be good if driver-devel were always
CC'd on the final patch.

I know Greg feels differently.

regards,
dan carpenter