[RFT PATCH 1/2] ARM: module: split core and init PLT sections

Ard Biesheuvel ard.biesheuvel at linaro.org
Tue Feb 21 09:35:44 PST 2017


On 21 February 2017 at 14:26, Angus Clark <angus at angusclark.org> wrote:
> Hi Ard,
>
> I have tested the patch and I think there is still a small issue.  At
> present, count_plts() assumes a PLT entry would only be required for
> undefined symbols.  However, if 'init' and 'core' are located far
> apart, then we may need an entry in the init PLT if some init code
> makes a call to a defined symbol in the core section.
>

Argh. You're absolutely right, another complication I did not
anticipate, unfortunately.

> As a quick test, I added an 'include_defined' argument to count_plts()
> which gets set for init relocs.  With this in place, the module loads
> fine and appears to function as expected.
>
> Happy to test any further versions :-)
>

Thanks, v2 coming up



More information about the linux-arm-kernel mailing list