[PATCH 2/2] coresight: etm3x: Correctly output counter values in sysfs node
Olav Haugan
ohaugan at codeaurora.org
Tue Feb 14 18:20:29 PST 2017
cntr_val_show function does not print the intended information. It is only
printing the latest counter value. Fix this.
Signed-off-by: Olav Haugan <ohaugan at codeaurora.org>
---
drivers/hwtracing/coresight/coresight-etm3x-sysfs.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c
index 4cbbd1313331..62acf07d604b 100644
--- a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c
+++ b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c
@@ -730,19 +730,29 @@ static ssize_t cntr_val_show(struct device *dev,
u32 val;
struct etm_drvdata *drvdata = dev_get_drvdata(dev->parent);
struct etm_config *config = &drvdata->config;
+ int buf_size = PAGE_SIZE;
if (!local_read(&drvdata->mode)) {
spin_lock(&drvdata->spinlock);
- for (i = 0; i < drvdata->nr_cntr; i++)
- ret += scnprintf(buf, PAGE_SIZE, "counter %d: %x\n",
- i, config->cntr_val[i]);
+ for (i = 0; i < drvdata->nr_cntr; i++) {
+ ret += scnprintf(&buf[ret], buf_size,
+ "counter %d: %x\n",
+ i, config->cntr_val[i]);
+ buf_size -= ret;
+ if (buf_size <= 0)
+ break;
+ }
spin_unlock(&drvdata->spinlock);
return ret;
}
for (i = 0; i < drvdata->nr_cntr; i++) {
val = etm_readl(drvdata, ETMCNTVRn(i));
- ret += scnprintf(buf, PAGE_SIZE, "counter %d: %x\n", i, val);
+ ret += scnprintf(&buf[ret], buf_size,
+ "counter %d: %x\n", i, val);
+ buf_size -= ret;
+ if (buf_size <= 0)
+ break;
}
return ret;
--
2.11.0
More information about the linux-arm-kernel
mailing list