[PATCH] ARM: dts: imx6q-cm-fx6: add analog audio support

Christopher Spinrath christopher.spinrath at rwth-aachen.de
Wed Feb 8 12:30:06 PST 2017


Hi Fabio,

thanks for the review!

On 02/07/2017 11:39 PM, Fabio Estevam wrote:
> On Tue, Feb 7, 2017 at 6:31 PM,  <christopher.spinrath at rwth-aachen.de> wrote:
>
>> +&audmux {
>> +       pinctrl-names = "default";
>> +       pinctrl-0 = <&pinctrl_audmux>;
>> +       status = "okay";
>> +
>> +       ssi2 {
>> +               fsl,audmux-port = <1>;
>> +               fsl,port-config = <
>> +                       (IMX_AUDMUX_V2_PTCR_RCLKDIR |
>> +                       IMX_AUDMUX_V2_PTCR_RCSEL(3 | 0x8) |
>> +                       IMX_AUDMUX_V2_PTCR_TCLKDIR |
>> +                       IMX_AUDMUX_V2_PTCR_TCSEL(3))
>> +                       IMX_AUDMUX_V2_PDCR_RXDSEL(3)
>> +               >;
>> +       };
>> +
>> +       pins5 {
>
> Just one minor nit: maybe pins4 since you are using AUD4 pins. Or
> maybe 'audmux4' as pins4 is too vague ?

Sounds good. Actually, CompuLab uses the term audmux4 themselves in the 
block diagram of the board.

Cheers,
Christopher

> Reviewed-by: Fabio Estevam <fabio.estevam at nxp.com>
>



More information about the linux-arm-kernel mailing list