[PATCH 10/22 v2] mtd: physmap_of: add a hook for Gemini flash probing

[Marek Vasut]

On 01/28/2017 10:50 PM, Linus Walleij wrote:
> In order to support device tree probing of Gemini NOR flash
> chips, a certain register in the syscon needs to be poked
> to enable parallel flash mode.
> 
> Such things used to happen in "necessarily different" board
> file code, and this indeed was also done for the Gemini, so
> the MTD driver could treat it as any memory-mapped NOR flash,
> but this is not the way in the future: board files need to
> go, and hardware concerns distributed down to the applicable
> drivers.
> 
> This adds a hook in the same way that the Versatile did: if
> the Kconfig symbol is not selected the net total of supporting
> Gemini should be zero bytes of added code. To live up to this
> promise, also the return value error print from the Versatile
> extra probe call get to be removed in this patch, all printing
> need to happen in the add-ons.
> 
> Cc: Janos Laube <janos.dev at gmail.com>
> Cc: Paulius Zaleckas <paulius.zaleckas at gmail.com>
> Cc: Hans Ulli Kroll <ulli.kroll at googlemail.com>
> Cc: Florian Fainelli <f.fainelli at gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> ---
> ChangeLog v1->v2:
> - Put a more elaborate description of the Kconfig option into
>   the Kconfig item, take this opportunity to also modify the
>   Versatile Kconfig entry which is equally terse.

Thanks!

> - Modify the Makefile to build the Gemini and Versatile drivers
>   based on their own config symbols and not based on an if on
>   their symbol, should have been done like that from the start.
> - Move a dev_info() to dev_dbg() in the driver.

[...]

> +	if (val & FLASH_WIDTH_16BIT) {
> +		if (map->bankwidth != 2)
> +			dev_warn(dev, "flash hardware say flash is 16 bit wide "
> +				 "but DT says it is %d bits wide\n",

Nit, please do not break printed strings, it is not possible to 'git
grep' for them if you do.

> +				 map->bankwidth * 8);
> +	} else {
> +		if (map->bankwidth != 1)
> +			dev_warn(dev, "flash hardware say flash is 8 bit wide "
> +				 "but DT says it is %d bits wide\n",

DTTO

> +				 map->bankwidth * 8);
> +	}
> +
> +	/* Activate parallel (NOR flash) mode */
> +	ret = regmap_update_bits(rmap, GLOBAL_MISC_CTRL,
> +				 FLASH_PADS_MASK,
> +				 SFLASH_PADS_DISABLE | NAND_PADS_DISABLE);
> +	if (ret) {
> +		dev_err(dev, "unable to set up physmap pads\n");
> +		return -ENODEV;
> +	}

[...]

Once you fix the nit above, add my:
Acked-by: Marek Vasut <marek.vasut at gmail.com>

-- 
Best regards,
Marek Vasut