[PATCH] [media] staging: bcm2835: mark all symbols as 'static'

Arnd Bergmann arnd at arndb.de
Thu Feb 2 04:34:51 PST 2017


On Thu, Feb 2, 2017 at 1:22 PM, Greg Kroah-Hartman
<gregkh at linuxfoundation.org> wrote:
> On Thu, Feb 02, 2017 at 01:11:36PM +0100, Arnd Bergmann wrote:
>> On Thu, Feb 2, 2017 at 1:04 PM, Arnd Bergmann <arnd at arndb.de> wrote:
>> > On Thu, Feb 2, 2017 at 12:34 PM, Arnd Bergmann <arnd at arndb.de> wrote:
>> >> I got a link error in allyesconfig:
>> >> Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera driver.")
>> >> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
>> >
>> > Please disregard this patch version, it's broken.
>>
>> Too late, I see it's already applied, I'll send a follow-up to revert
>> the first hunk.
>
> Ah, I could have just dropped your patch (it's a testing branch that I
> can rebase), but I took your newer patch that fixed it up, so all is
> good.
>
> That's what I get for applying patches too quickly :)

I should really have been more careful about testing. I had the first
version in my
working tree while doing randconfig tests. None of the new randconfig builds
ran into the issue (the driver gets rarely enabled because of its dependencies),
and the original failure had already been marked as fixed in my build system
after an earlier patch only changed one of the prototypes.

    Arnd



More information about the linux-arm-kernel mailing list