[alsa-devel] [PATCH v1] ASoC: bcm2835: Remove redundant channel checking code in hw_params

[Mark Brown]

On Wed, Feb 01, 2017 at 10:05:18PM +1100, Matt Flax wrote:
> On 01/02/17 21:53, Mark Brown wrote:

> > If those cards add support for higher channel counts they should be
> > adding real support for that in the driver, not just hacking out
> > defensive code.  If the device can usefully do 8 channels then modify
> > the driver to do 8 channels.  Otherwise people are going to need to
> > modify the driver anyway to remove the limits in the constraints.

> Indeed the AudioInjector Octo sound card is currently operating @ 8 channels
> out on the bcm2835 silicon. It has been tested on both the Pi 2 and Pi 3.

> Do you mean that I should increase bcm2835_i2s_dai.channels_max to 8 ?

Yes, implementing it properly is fine.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170201/2603fd0d/attachment.sig>