[PATCH] [V3] mmc: mmci: add missing include of mmci_qcom_dml.h

Ben Dooks ben.dooks at codethink.co.uk
Thu Jun 16 11:47:32 PDT 2016

Fix the missing declarations of dml_start_xfer() and
dml_hw_init() by including mmci_qcom_dml.h to fix the
following warnings:

drivers/mmc/host/mmci_qcom_dml.c:57:6: warning: symbol 'dml_start_xfer' was not declared. Should it be static?
drivers/mmc/host/mmci_qcom_dml.c:122:5: warning: symbol 'dml_hw_init' was not declared. Should it be static?

Since the module build doesn't export symbols, also
export the symbols from the mmci_qcom_dml.c file as
otherwise the module link process won't work.

It is possible this also fixes up module loading when
both drivers are built as modules and not inserted in
the correct order.

Note, since this is a very small addition to the mmci
module, it would better to build it into the main mmci
driver (either by direct copy, or multiple linked

Signed-off-by: Ben Dooks <ben.dooks at codethink.co.uk>
  - deal with module build errors
  - add original authour and update list of recipients
Cc: Srinivas Kandagatla <srinivas.kandagatla at linaro.org>
Cc: Ulf Hansson <ulf.hansson at linaro.org>
Cc: linux-mmc at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
 drivers/mmc/host/mmci_qcom_dml.c | 3 +++
 drivers/mmc/host/mmci_qcom_dml.h | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c
index 2b7fc37..06858bd 100644
--- a/drivers/mmc/host/mmci_qcom_dml.c
+++ b/drivers/mmc/host/mmci_qcom_dml.c
@@ -18,6 +18,7 @@
 #include <linux/mmc/host.h>
 #include <linux/mmc/card.h>
 #include "mmci.h"
+#include "mmci_qcom_dml.h"
 /* Registers */
 #define DML_CONFIG			0x00
@@ -97,6 +98,7 @@ void dml_start_xfer(struct mmci_host *host, struct mmc_data *data)
 	/* make sure the dml is configured before dma is triggered */
 static int of_get_dml_pipe_index(struct device_node *np, const char *name)
@@ -175,3 +177,4 @@ int dml_hw_init(struct mmci_host *host, struct device_node *np)
 	return 0;
diff --git a/drivers/mmc/host/mmci_qcom_dml.h b/drivers/mmc/host/mmci_qcom_dml.h
index 6e405d0..d77873d 100644
--- a/drivers/mmc/host/mmci_qcom_dml.h
+++ b/drivers/mmc/host/mmci_qcom_dml.h
@@ -15,7 +15,7 @@
 #ifndef __MMC_QCOM_DML_H__
 #define __MMC_QCOM_DML_H__
 int dml_hw_init(struct mmci_host *host, struct device_node *np);
 void dml_start_xfer(struct mmci_host *host, struct mmc_data *data);

More information about the linux-arm-kernel mailing list