[PATCH v3 4/5] ARM: dts: sun8i-h3: Add R_PIO controller node to the dtsi
Krzysztof Adamski
k at japko.eu
Mon Feb 8 00:39:12 PST 2016
On Fri, Feb 05, 2016 at 05:46:32PM +0800, Chen-Yu Tsai wrote:
>On Thu, Feb 4, 2016 at 7:33 AM, Krzysztof Adamski <k at japko.eu> wrote:
>> Add the corresponding device node for R_PIO on H3 to the dtsi. Support
>> for the controller was added in earlier commit.
>>
>> Signed-off-by: Krzysztof Adamski <k at japko.eu>
>> ---
>> arch/arm/boot/dts/sun8i-h3.dtsi | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
>> index bb37f52..f618a95 100644
>> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
>> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
>> @@ -517,5 +517,17 @@
>> compatible = "allwinner,sun6i-a31-clock-reset";
>> #reset-cells = <1>;
>> };
>> +
>> + r_pio: pinctrl at 01f02c00 {
>> + compatible = "allwinner,sun8i-h3-r-pinctrl";
>> + reg = <0x01f02c00 0x400>;
>> + interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&apb0_gates 0>;
>> + resets = <&apb0_reset 0>;
>> + gpio-controller;
>> + #gpio-cells = <3>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>
>This should be 3: bank number + pin number + flags.
>The rest looks good.
Nicly spotted. I took it from pio description in the same file. So
there's a bug there too.
More information about the linux-arm-kernel
mailing list