[PATCH] ARM: dts: add PM8058 LEDs to the APQ8060 Dragonboard

Linus Walleij linus.walleij at linaro.org
Thu Aug 18 06:10:39 PDT 2016


On Wed, Aug 17, 2016 at 11:40 PM, Jacek Anaszewski
<jacek.anaszewski at gmail.com> wrote:

>> +                               led at 48 {
>> +                                       /*
>> +                                        * The keypad LED @0x48 is routed
>> to
>> +                                        * the sensor board where it is
>> +                                        * connected to an infrared LED
>> +                                        * SFH4650 (60mW, @850nm) next to
>> the
>> +                                        * ambient light and proximity
>> sensor
>> +                                        * Capella Microsystems CM3605.
>> +                                        */
>> +                                       compatible =
>> "qcom,pm8058-keypad-led";
>> +                                       reg = <0x48>;
>> +                                       label = "proximity0";
>
>
> In DT bindings documentation it was changed to "pm8050:white:keypad" to
> adhere to the LED class device naming convention. I assume that having
> it in this form is an omission here.

Hm right. Given the usecase here, what do you say about naming
it:

"pm8058:infrared:proximitysensor"

?

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list