[PATCH 12/37] ARM: dts: dove-sbc-a510: Fix regulator enable GPIO polarity

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Oct 12 14:12:41 PDT 2015


The enable GPIO is active low, but is flagged as active high in the gpio
property. As the gpio property flags are currently unused by the driver
this doesn't cause any issue for now, but will break later if the driver
starts making use of the flags. Fix it.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 arch/arm/boot/dts/dove-sbc-a510.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Cc: Jason Cooper <jason at lakedaemon.net>
Cc: Andrew Lunn <andrew at lunn.ch>
Cc: Gregory Clement <gregory.clement at free-electrons.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth at gmail.com>

diff --git a/arch/arm/boot/dts/dove-sbc-a510.dts b/arch/arm/boot/dts/dove-sbc-a510.dts
index 288e707dea99..3bc5c96483be 100644
--- a/arch/arm/boot/dts/dove-sbc-a510.dts
+++ b/arch/arm/boot/dts/dove-sbc-a510.dts
@@ -82,7 +82,7 @@
 			regulator-name = "USB Power";
 			regulator-min-microvolt = <5000000>;
 			regulator-max-microvolt = <5000000>;
-			gpio = <&gpio_ext 0 GPIO_ACTIVE_HIGH>;
+			gpio = <&gpio_ext 0 GPIO_ACTIVE_LOW>;
 		};
 
 		mmc_power: regulator at 3 {
@@ -90,7 +90,7 @@
 			regulator-name = "MMC Power";
 			regulator-min-microvolt = <3300000>;
 			regulator-max-microvolt = <3300000>;
-			gpio = <&gpio_ext 13 GPIO_ACTIVE_HIGH>;
+			gpio = <&gpio_ext 13 GPIO_ACTIVE_LOW>;
 		};
 	};
 };
-- 
2.4.9




More information about the linux-arm-kernel mailing list