[PATCH] ARM: footbridge: enable dc21285 mtd map in defconfig
Russell King - ARM Linux
linux at arm.linux.org.uk
Fri May 29 01:42:59 PDT 2015
On Fri, May 29, 2015 at 08:49:42AM +0200, Uwe Kleine-König wrote:
> On Thu, May 28, 2015 at 10:05:20PM +0100, Russell King - ARM Linux wrote:
> > On Thu, May 28, 2015 at 12:55:58PM -0700, Brian Norris wrote:
> > > On Thu, May 28, 2015 at 09:46:20PM +0200, Uwe Kleine-König wrote:
> > > > This driver fails to build since release 3.2. Improve compile coverage
> > > > by enabling this driver in the footbridge defconfig
> > >
> > > Actually, it did build, but it just had alarming warnings. I don't think
> > > those warnings actually affected anything at runtime, except for lock
> > > debugging (if enabled).
> > >
> > > But anyway, the change looks good, and I'm doing this in my local build
> > > tests now, so:
> > >
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > >
> > > Acked-by: Brian Norris <computersforpeace at gmail.com>
> > I'd say no to this - some boards have old (28F008) flash on them, which
> > (iirc) doesn't take kindly to being probed by MTD.
> Is this a bug? I'd say keeping the driver disabled in the defconfig just
> papers over a problem.
Yes it is papering over a bug, but...
(1) I didn't add the driver.
(2) I didn't see the addition of the driver.
(3) I don't have the resources to be able to recover from a screwed up
flash bricking my footbridge platforms.
So, I wouldn't even like to /try/ enabling it to see whether it doesn't
have the behaviour I referred to.
> Maybe modify the driver to not probe unless a kernel parameter is given?
Possibly an alternative solution.
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
More information about the linux-arm-kernel