[PATCH] ARM: footbridge: enable dc21285 mtd map in defconfig

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Thu May 28 23:49:42 PDT 2015


On Thu, May 28, 2015 at 10:05:20PM +0100, Russell King - ARM Linux wrote:
> On Thu, May 28, 2015 at 12:55:58PM -0700, Brian Norris wrote:
> > On Thu, May 28, 2015 at 09:46:20PM +0200, Uwe Kleine-König wrote:
> > > This driver fails to build since release 3.2. Improve compile coverage
> > > by enabling this driver in the footbridge defconfig
> > 
> > Actually, it did build, but it just had alarming warnings. I don't think
> > those warnings actually affected anything at runtime, except for lock
> > debugging (if enabled).
> > 
> > But anyway, the change looks good, and I'm doing this in my local build
> > tests now, so:
> > 
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > 
> > Acked-by: Brian Norris <computersforpeace at gmail.com>
> 
> I'd say no to this - some boards have old (28F008) flash on them, which
> (iirc) doesn't take kindly to being probed by MTD.
Is this a bug? I'd say keeping the driver disabled in the defconfig just
papers over a problem.
Maybe modify the driver to not probe unless a kernel parameter is given?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list