[PATCH v3 2/6] mmc: sdhci-esdhc-imx: add tuning-step seting support

Dong Aisheng aisheng.dong at freescale.com
Thu Jul 30 21:41:49 PDT 2015


On Thu, Jul 30, 2015 at 06:25:06PM +0200, Jan Lübbe wrote:
> On Mi, 2015-07-29 at 17:03 +0800, Haibo Chen wrote:
> > tuning-step is the delay cell steps in tuning procedure. The default
> > value of tuning-step is 1. For imx6 series usdhc, tuning procedure can
> > be passed when the tuning-step value is 1. But imx7d usdhc need the
> > tuning-step value as 2, otherwise it can't pass the tuning procedure.
> > 
> > So this patch add the tuning-step setting in driver, so that user can
> > set the tuning-step value in dts.
> 
> From your description, the correct tuning-step value only depends on the
> SoC. Why not derive it from the compatible string?
> 

'tuning-step' actually depends on board and card.
The commit message should be reformed a bit.

Regards
Dong Aisheng

> Regards,
> Jan Lübbe
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 



More information about the linux-arm-kernel mailing list