[PATCH v3 1/1] Serial: imx: add dev_pm_ops to support suspend to ram/disk

Fabio Estevam festevam at gmail.com
Wed Jul 29 14:45:35 PDT 2015


On Wed, Jul 29, 2015 at 6:41 PM, Shenwei Wang
<Shenwei.Wang at freescale.com> wrote:

>> clk_enable() may fail, so you should check its return value.
>
> The check seems a little superfluous because the failure condition for clk_enable is
> (clk == NULL || IS_ERR(clk))
> Once this function is called which means the initialization of the driver is successful.

Not superfluos. You can't assume that clk_enable() will always be
successful. Better check its return value.



More information about the linux-arm-kernel mailing list