[PATCH 3/3] ARM: errata 430973: move !ARCH_MULTIPLATFORM to Kconfig

Russell King - ARM Linux linux at arm.linux.org.uk
Sun Jul 26 15:51:45 PDT 2015


On Fri, Jul 24, 2015 at 02:16:06AM +0200, Sebastian Reichel wrote:
> Hi Russel,
> 
> On Thu, Jul 23, 2015 at 01:35:53PM +0100, Russell King - ARM Linux wrote:
> > On Thu, Jul 23, 2015 at 02:48:03AM +0200, Sebastian Reichel wrote:
> > > Having the !ARCH_MULTIPLATFORM dependency in the Kconfig file results
> > > in one option less to think about when configuring the kernel.
> > 
> > > -#if defined(CONFIG_ARM_ERRATA_430973) && !defined(CONFIG_ARCH_MULTIPLATFORM)
> > > +#ifdef CONFIG_ARM_ERRATA_430973
> > >  	teq	r3, #0x00100000			@ only present in r1p*
> > >  	mrceq	p15, 0, r0, c1, c0, 1		@ read aux control register
> > >  	orreq	r0, r0, #(1 << 6)		@ set IBE to 1
> > 
> > NAK.  Please read the mailing list history, I'm not repeating myself
> > again on this.  Thanks.
> 
> It's a bit hard to search the mailing list history without a bit
> more information.

You were Cc'd on the previous round of review...

> I guess you prefer to just add the !ARCH_MULTIPLATFORM dependency to
> the Kconfig entry without removing the additional check in the code?

I was referring to the above change.

However, having discussed with Will Deacon and checked the manuals, I
think the change is okay after all: the auxillary control register is
banked on secure parts, and the bit we'll be trying to change will be
read-only in non-secure mode - and importantly won't fault.

So, the change is fine, thanks.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.



More information about the linux-arm-kernel mailing list