[PATCH v6 04/13] clk: qcom: gdsc: Manage clocks with !CONFIG_PM

Rajendra Nayak rnayak at codeaurora.org
Thu Jul 23 01:35:48 PDT 2015


[]..

>> +
>> +#ifndef CONFIG_PM
>> +static void enable_clock(struct device *dev, const char *con_id)
>> +{
>> +    struct clk *clk;
>> +
>> +    clk = clk_get(dev, con_id);
>> +    if (!IS_ERR(clk)) {
>> +        clk_prepare_enable(clk);
>> +        clk_put(clk);
>> +    }
>> +}
>> +
>> +static void disable_clock(struct device *dev, const char *con_id)
>> +{
>> +    struct clk *clk;
>> +
>> +    clk = clk_get(dev, con_id);
>> +    if (!IS_ERR(clk)) {
>> +        clk_disable_unprepare(clk);
>> +        clk_put(clk);
>> +    }
>> +}
>
> Is there a reason why this whole patch isn't generic code? I recall some
> discussion but I forgot now and there isn't any mention of why this
> isn't generic code in the commit text.

If by generic code, you mean using PM clocks, then this thread should
give some context..
http://www.spinics.net/lists/arm-kernel/msg414072.html



More information about the linux-arm-kernel mailing list