[PATCH] bcma: populate bus DT subnodes as platform_device-s

Kalle Valo kvalo at codeaurora.org
Wed Jul 22 23:06:28 PDT 2015


Rafał Miłecki <zajec5 at gmail.com> writes:

>> +       if (bus->host_pdev) {
>> +               struct device *dev = &bus->host_pdev->dev;
>> +
>> +               of_platform_populate(dev->of_node, of_default_bus_match_table,
>> +                                    NULL, dev);
>> +       }
>> +
>
> This caused a compile error when using bcma as module:
> ERROR: "of_default_bus_match_table" [drivers/bcma/bcma.ko] undefined!
>
> There are two options I guess:
> 1) Export of_default_bus_match_table
> 2) Use some better condition like
> if (IS_BUILTIN(CONFIG_BCMA) && bus->host_pdev)
>
> Unfortunately I'm on my long holidays right now.
>
> Hauke: do you think you can find a moment to handle this?

I can cook up a patch which uses IS_BUILTIN() so that we get the build
working again. You can fix this better once you come back.

> Sorry for the problem :|

No worries, enjoy your vacation :)

-- 
Kalle Valo



More information about the linux-arm-kernel mailing list