[PATCH v8 2/9] nvmem: Add a simple NVMEM framework for consumers

Srinivas Kandagatla srinivas.kandagatla at linaro.org
Wed Jul 22 00:26:36 PDT 2015


Thanks Stefan,

On 21/07/15 17:25, Stefan Wahren wrote:
>> +
>> >+ addr = of_get_property(cell_np, "reg", &len);
>> >+ if (!addr || (len < 2 * sizeof(int))) {
> I'm not sure, but shouldn't be sizeof(u32) more portable?
>
yes it makes sense, I will change it.
>> >[...]
>> >+
>> >+ addr = of_get_property(cell_np, "bits", &len);
>> >+ if (addr && len == (2 * sizeof(int))) {
> dito
yep.

--srini



More information about the linux-arm-kernel mailing list