[PATCH v2 3/7] KVM: irqchip: convey devid to kvm_set_msi

Pavel Fedin p.fedin at samsung.com
Fri Jul 17 03:21:23 PDT 2015


 Hello!

> >> > +	} else if (!msi->flags)
> >> > +		return -EINVAL;
> >  Did you mean "if (msg->flags)" here (inverted condition)?
> 
> Indeed, and also you need { } around the return for the QEMU coding
> standard.

 It's kernel and not qemu :)

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia




More information about the linux-arm-kernel mailing list