[PATCH] Subject: pinctrl: imx1-core: Fix debug output in .pin_config_set callback

Linus Walleij linus.walleij at linaro.org
Fri Jul 17 00:58:01 PDT 2015


On Fri, Jul 17, 2015 at 9:38 AM, Uwe Kleine-König
<u.kleine-koenig at pengutronix.de> wrote:

> imx1_pinconf_set assumes that the array of pins in struct
> imx1_pinctrl_soc_info can be indexed by pin id to get the
> pinctrl_pin_desc for a pin. This used to be correct up to commit
> 607af165c047 which removed some entries from the array and so made it
> wrong to access the array by pin id.
>
> The result of this bug is a wrong pin name in the output for small pin
> ids and an oops for the bigger ones.
>
> This patch is the result of a discussion that includes patches by Markus
> Pargmann and Chris Ruehl.
>
> Fixes: 607af165c047 ("pinctrl: i.MX27: Remove nonexistent pad definitions")
> Cc: stable at vger.kernel.org
> Reported-by: Chris Ruehl <chris.ruehl at gtsys.com.hk>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Patch applied for fixes with Markus' review tag.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list