[PATCH v2 03/10] arm64: esr.h type fixes and cleanup
Dave.Martin at arm.com
Tue Jul 14 09:53:12 PDT 2015
On Tue, Jul 14, 2015 at 04:54:46PM +0100, Mark Rutland wrote:
> On Mon, Jul 13, 2015 at 02:25:50PM +0100, Dave P Martin wrote:
> > ESR_ELx is a 32-bit register, so it is not necessary for all the
> > template values defined by esr.h to be forced to 64-bit (long).
> While it's potentially misleading, does forcing these to be 64-bit cause
> a real issue? If so, it would be good to mention in the commit message.
GCC (at least, >= 4.9.2) generates warnings when these values, or
expressions involving them, are assigned to 32-bit structure members.
However, Will wasn't a big fan of my original solution to this problem,
so I'll take a final look before posting the final series to see if
there's a less invasive approach.
An explicit cast at the site of the truncating assignment(s) might do
> > This patch introduces a UINT() macro analogous to UL(), and applies
> > it consistently. (Unfortunately, the more succinct U and UI names
> > are already used in unrelated code, and cause conflicts since
> > memory.h is widely included.)
> > Since this change touches many lines already, I've taken the
> > opportunity to squash some redundant parentheses and bogus
> > whitespace at the same time.
> > The missing include of <asm/memory.h> (for UL(), UINT() etc.) is
> > also added.
More information about the linux-arm-kernel