[PATCH v2 10/13] pinctrl: kill off set_irq_flags usage

Tomasz Figa tomasz.figa at gmail.com
Sun Jul 12 08:45:58 PDT 2015


Hi,

2015-07-12 23:26 GMT+09:00 Rob Herring <robh at kernel.org>:
> set_irq_flags is ARM specific with custom flags which have genirq
> equivalents. Convert drivers to use the genirq interfaces directly, so we
> can kill off set_irq_flags. The translation of flags is as follows:
>
> IRQF_VALID -> !IRQ_NOREQUEST
> IRQF_PROBE -> !IRQ_NOPROBE
> IRQF_NOAUTOEN -> IRQ_NOAUTOEN
>
> For IRQs managed by an irqdomain, the irqdomain core code handles clearing
> and setting IRQ_NOREQUEST already, so there is no need to do this in
> .map() functions and we can simply remove the set_irq_flags calls. Some
> users also set IRQ_NOPROBE and this has been maintained although it is not
> clear that is really needed. There appears to be a great deal of blind
> copy and paste of this code.
>
> Signed-off-by: Rob Herring <robh at kernel.org>
> Acked-by: Linus Walleij <linus.walleij at linaro.org>
> Cc: Stephen Warren <swarren at wwwdotorg.org>
> Cc: Lee Jones <lee at kernel.org>
> Cc: Matthias Brugger <matthias.bgg at gmail.com>
> Cc: Tomasz Figa <tomasz.figa at gmail.com>
> Cc: Thomas Abraham <thomas.abraham at linaro.org>
> Cc: Kukjin Kim <kgene at kernel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski at samsung.com>
> Cc: linux-gpio at vger.kernel.org
> Cc: linux-rpi-kernel at lists.infradead.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-mediatek at lists.infradead.org
> Cc: linux-samsung-soc at vger.kernel.org
> ---
>  drivers/pinctrl/bcm/pinctrl-bcm2835.c         | 1 -
>  drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 --
>  drivers/pinctrl/pinctrl-single.c              | 5 -----
>  drivers/pinctrl/samsung/pinctrl-exynos.c      | 1 -
>  drivers/pinctrl/samsung/pinctrl-exynos5440.c  | 1 -
>  drivers/pinctrl/samsung/pinctrl-s3c24xx.c     | 2 --
>  drivers/pinctrl/samsung/pinctrl-s3c64xx.c     | 2 --

For drivers/pinctrl/samsung:

Acked-by: Tomasz Figa <tomasz.figa at gmail.com>

Best regards,
Tomasz



More information about the linux-arm-kernel mailing list