[PATCH 1/2] power: reset: at91: add sama5d3 reset function
alexandre.belloni at free-electrons.com
Thu Jul 9 22:56:58 PDT 2015
On 09/07/2015 at 20:14:38 -0700, Guenter Roeck wrote :
> > This patch introduces a new compatible string: "atmel,sama5d3-rstc" for the
> > reset driver of sama5d3 and later chips.
> > As in sama5d3 or later chips, we don't have to shutdown the DDR controller
> > before reset. Shutdown the DDR controller before reset is a workaround to
> > avoid DDR signal driving the bus, but since sama5d3 and later chips there is
> > no such a conflict.
> > That means:
> > 1. the sama5d3 reset function only need to write the rstc register and
> > return.
> > 2. for sama5d3, we can remove the code related with DDR controller as we
> > don't use it at all.
> Sorry, I don't get it. Doesn't that mean there are two distinct logical
> changes, which would ask for two separate patches ?
I would agree with Josh and I think that only one patch is needed. There
is only one change, the removal of the workaround for sama5d3 and later.
As the workaround is using a table of compatibles to remap the ram
controller and the one for sama5d3 is not used because it is not needed,
I think it makes sense to remove it in that same patch. The logical
change here is the removal of the workaround.
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
More information about the linux-arm-kernel