[PATCH] pinctrl: imx1-core: Fix debug output pin array index

[Uwe Kleine-König]

Hi,

On Thu, Jul 09, 2015 at 03:30:36PM +0200, Markus Pargmann wrote:
> > b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> > index 5ac59fb..8408bd8 100644
> > --- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> > +++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
> > @@ -403,14 +403,16 @@ static int imx1_pinconf_set(struct pinctrl_dev *pctldev,
> >  			     unsigned num_configs)
> >  {
> >  	struct imx1_pinctrl *ipctl = pinctrl_dev_get_drvdata(pctldev);
> > -	const struct imx1_pinctrl_soc_info *info = ipctl->info;
> > +	struct pin_desc *desc;
> >  	int i;
> > 
> > +	desc = pin_desc_get(pctldev, pin_id);
> 
> For the rest of this function pin_desc_get() is not necessary. This is
> not a simple function call but a radix tree lookup as far as I can see.
> I am not sure how important this debugging information is and how
> expensive this function call is?!
If it's moved into the call to pr_debug it should be optimized away when
debugging is off. That together with a merge of Chris' and mine commit
log and I'm happy.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |