[PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support

Paul Bolle pebolle at tiscali.nl
Wed Jul 8 13:39:56 PDT 2015

Hi Masahiro,

On wo, 2015-07-08 at 14:01 +0900, Masahiro Yamada wrote:
> Actually, most of pinctrl drivers are boolean, but most of them
> conventionally have MODULE_AUTHOR, THIS_MODULE, etc.
> I do not think it looks so weird.  Thought?

It's a rather common pattern, but I think it's an anti-pattern
nevertheless. See the discussion that Shobhit Kumar, Paul Gortmaker, and
I had starting in https://lkml.org/lkml/2015/6/20/63 .

Please let me know if you're unconvinced by the arguments brought
forward by both Pauls in that discussion.


Paul Bolle

More information about the linux-arm-kernel mailing list