[PATCH 2/4] ARM: dts: Extend exynos5250-pinctrl nodes using labels instead of paths

Krzysztof Kozlowski k.kozlowski at samsung.com
Wed Jul 8 01:29:26 PDT 2015

On 08.07.2015 14:36, Javier Martinez Canillas wrote:
> A previously defined Device Tree node, can be extended either by defining
> a node using the same full path or by creating a label for the node and
> referencing to it.
> Using full paths is more error prone since if there was a typo error, a
> new node will be created instead of extending the node as it was desired.
> This will lead to run-time errors that could be hard to detect.
> A misstyped label on the other hand, will cause a dtc compile error which


> makes it easier to detect the mistake since happens at build-time instead.
> Signed-off-by: Javier Martinez Canillas <javier at osg.samsung.com>
> ---
>  arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 1600 ++++++++++++++---------------
>  1 file changed, 799 insertions(+), 801 deletions(-)

I didn't look carefully enough to call it a review (I trust the 'diff'
of yours) but it seems fine to me:

Acked-by: Krzysztof Kozlowski <k.kozlowski at samsung.com>

Best regards,

More information about the linux-arm-kernel mailing list