[PATCH] thermal: consistently use int for temperatures

Peter Feuerer peter at piie.net
Wed Jul 8 01:11:24 PDT 2015

Sascha Hauer writes:

> The thermal code uses int, long and unsigned long for temperatures
> in different places.
> Using an unsigned type limits the thermal framework to positive
> temperatures without need. Also several drivers currently will report
> temperatures near UINT_MAX for temperatures below 0°C. This will probably
> immediately shut the machine down due to overtemperature if started below
> 0°C.
> 'long' is 64bit on several architectures. This is not needed since INT_MAX °mC
> is above the melting point of all known materials.
> Consistently use a plain 'int' for temperatures throughout the thermal code and
> the drivers. This only changes the places in the drivers where the temperature
> is passed around as pointer, when drivers internally use another type this is
> not changed.
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> Cc: Zhang Rui <rui.zhang at intel.com>
> Cc: Eduardo Valentin <edubezval at gmail.com>
> Cc: linux-pm at vger.kernel.org
> Cc: linux-kernel at vger.kernel.org
> Cc: Jean Delvare <jdelvare at suse.de>
> Cc: Peter Feuerer <peter at piie.net>
> Cc: Heiko Stuebner <heiko at sntech.de>
> Cc: Lukasz Majewski <l.majewski at samsung.com>
> Cc: Stephen Warren <swarren at wwwdotorg.org>
> Cc: Thierry Reding <thierry.reding at gmail.com>
> Cc: linux-acpi at vger.kernel.org
> Cc: platform-driver-x86 at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-omap at vger.kernel.org
> Cc: linux-samsung-soc at vger.kernel.org
> Cc: Guenter Roeck <linux at roeck-us.net>
> Cc: Rafael J. Wysocki <rjw at rjwysocki.net>
> Cc: Maxime Ripard <maxime.ripard at free-electrons.com>
> Cc: Darren Hart <dvhart at infradead.org>
> Cc: lm-sensors at lm-sensors.org
> ---



>  drivers/platform/x86/acerhdf.c                     |  9 ++++----
>  drivers/thermal/gov_bang_bang.c                    |  5 ++--

Reviewed-by: Peter Feuerer <peter at piie.net>



More information about the linux-arm-kernel mailing list