[PATCH] ARM: psci: boot_secondary: replace __pa with virt_to_idmap

Mark Rutland mark.rutland at arm.com
Thu Jul 2 03:55:39 PDT 2015

> > I could retain the struct and packing functions for the two cases you
> > mention, but it seemed somewhat misleading. I'll see if I can figure out
> > something better than a raw hex value.
> What's wrong with a few #defines for this?


> It obviously is well enough defined in existing pre-v1.0
> implementations as there is an existing structure to the parameter.
> Can we not do something like:
> #define PSCI_POWER_STATE_ID(x)			(x)
> #define PSCI_POWER_STATE_TYPE_POWER_DOWN	0x000100000
> #define PSCI_POWER_STATE_AFFINITY_LEVEL(x)	((x) << 24)

Looks good.

We already have some constants defined in a UAPI header, so I'll see
about reusing those.


More information about the linux-arm-kernel mailing list