[PATCH] mmc: pwrseq_simple: Fix regression with optional GPIOs

Ulf Hansson ulf.hansson at linaro.org
Mon Dec 28 04:18:11 PST 2015


On 18 December 2015 at 23:31, Tony Lindgren <tony at atomide.com> wrote:
> * Ulf Hansson <ulf.hansson at linaro.org> [151218 14:20]:
>> On 18 December 2015 at 17:14, Tony Lindgren <tony at atomide.com> wrote:
>> > * Ulf Hansson <ulf.hansson at linaro.org> [151207 16:20]:
>> >> +Linus
>> >>
>> >> On 7 December 2015 at 23:54, Tony Lindgren <tony at atomide.com> wrote:
>> >> > Commit ce037275861e ("mmc: pwrseq_simple: use GPIO descriptors array API")
>> >> > changed the handling MMC power sequence so GPIOs no longer are optional.
>> >> >
>> >> > This broke SDIO WLAN at least for omap5 that can't yet use the reset GPIOs
>> >> > with pwrseq_simple as a wait is needed after enabling the SDIO device.
>> >>
>> >> Can you elaborate on this. Did it break omap5 or not? :-)
>> >
>> > Ulf, is this patch queued for v4.4 as a regression fix? I don't see it
>> > in Linux next or mainline trees?
>>
>> Ohh, I guess there where some misunderstanding. I made a bunch of
>> comments on your patch as well, so I have been expecting a new
>> version.
>
> Well this $subject patch was intended as a regression fix for v4.4-rc cycle.
> All the other things discussed are not fixes but new features instead.
>
>> Sorry if that was unclear!
>
> I think this patch should be still fine as is, care to take a look again?

No, the patch have issues that needs to be fixed.
http://www.spinics.net/lists/linux-mmc/msg34399.html

Kind regards
Uffe



More information about the linux-arm-kernel mailing list