[PATCH] ARM: BCM5301X: select GPIOLIB as optional

[Rafał Miłecki]

On 20 September 2014 19:00, Alexander Shiyan <shc_work at mail.ru> wrote:
> Sat, 20 Sep 2014 18:41:22 +0200 от Rafał Miłecki <zajec5 at gmail.com>:
>> All routers (or 99% of them) based on BCM5301X use GPIOs to control LEDs
>> and buttons.
>>
>> Signed-off-by: Rafał Miłecki <zajec5 at gmail.com>
>> ---
>>  arch/arm/mach-bcm/Kconfig | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
>> index fc93800..d967c98 100644
>> --- a/arch/arm/mach-bcm/Kconfig
>> +++ b/arch/arm/mach-bcm/Kconfig
>> @@ -80,8 +80,10 @@ config ARCH_BCM2835
>>
>>  config ARCH_BCM_5301X
>>       bool "Broadcom BCM470X / BCM5301X ARM SoC" if ARCH_MULTI_V7
>> +     select ARCH_WANT_OPTIONAL_GPIOLIB
>>       select ARM_GIC
>>       select CACHE_L2X0
>> +     select GPIOLIB
> ...
>
> GPIOLIB is selected automatically by ARCH_WANT_OPTIONAL_GPIOLIB.

I don't think so, I believe selecting is done by ARCH_REQUIRE_GPIOLIB only.

Reading drivers/gpio/Kconfig confuses me a bit. I believe I should
select ARCH_WANT_OPTIONAL_GPIOLIB, because the board can boot without
GPIOs, they are needed for LEDs and buttons only. Also most users will
want LEDs and buttons, so I "select GPIOLIB".

-- 
Rafał