[PATCH] PCI: mvebu: Fix uninitialized variable in mvebu_get_tgt_attr()
Arnd Bergmann
arnd at arndb.de
Fri Sep 5 11:34:14 PDT 2014
On Friday 05 September 2014 20:20:44 Thomas Petazzoni wrote:
> Hum, I think I would actually prefer something like:
>
> if (DT_FLAGS_TO_TYPE(flags) == DT_TYPE_IO)
> rtype = IORESOURCE_IO;
> else if (DT_FLAGS_TO_TYPE(flags) == DT_TYPE_MEM32)
> rtype = IORESOURCE_MEM;
> + else
> + continue;
>
> So that we're explicit with the fact that we only care about I/O and
> MEM32 resource types.
Agreed, that looks better than my patch as well.
Arnd
More information about the linux-arm-kernel
mailing list