[PATCH] PCI: mvebu: Fix uninitialized variable in mvebu_get_tgt_attr()
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Fri Sep 5 11:20:44 PDT 2014
Dear Bjorn Helgaas,
On Fri, 5 Sep 2014 11:41:22 -0600, Bjorn Helgaas wrote:
> This fix looks right to me. I added a stable tag as follows. Thomas
> and/or Jason, and you ack this?
Hum, I think I would actually prefer something like:
if (DT_FLAGS_TO_TYPE(flags) == DT_TYPE_IO)
rtype = IORESOURCE_IO;
else if (DT_FLAGS_TO_TYPE(flags) == DT_TYPE_MEM32)
rtype = IORESOURCE_MEM;
+ else
+ continue;
So that we're explicit with the fact that we only care about I/O and
MEM32 resource types.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the linux-arm-kernel
mailing list