[PATCH v5 1/5] ARM: EXYNOS: Add generic cpu power control functions for all exynos based SoCs

Abhilash Kesavan kesavan.abhilash at gmail.com
Sun May 18 19:42:28 PDT 2014


Hi Tomasz,

On Sat, May 17, 2014 at 6:02 AM, Tomasz Figa <tomasz.figa at gmail.com> wrote:
>
>
> On 16.05.2014 07:07, Abhilash Kesavan wrote:
>> Hi Tomasz,
>>
>> On Fri, May 16, 2014 at 2:41 AM, Tomasz Figa <tomasz.figa at gmail.com> wrote:
>>> Hi Abhilash,
>>>
>>> On 13.05.2014 12:12, Abhilash Kesavan wrote:
>>>> On Tue, May 13, 2014 at 7:54 AM, Kukjin Kim <kgene.kim at samsung.com> wrote:
>>>
>>> [snip]
>>>
>>>>>> diff --git a/arch/arm/mach-exynos/regs-pmu.h b/arch/arm/mach-exynos/regs-
>>>>>> pmu.h
>>>>>> index 4f6a256..0bdfcbc 100644
>>>>>> --- a/arch/arm/mach-exynos/regs-pmu.h
>>>>>> +++ b/arch/arm/mach-exynos/regs-pmu.h
>>>>>> @@ -121,6 +121,12 @@
>>>>>>
>>>>>>  #define S5P_CHECK_SLEEP                              0x00000BAD
>>>>>>
>>>>>> +#define EXYNOS_ARM_CORE0_CONFIGURATION               S5P_PMUREG(0x2000)
>>>>>
>>>>> This can be put in order of address.
>>>> OK, will fix.
>>>>>
>>>>>> +#define EXYNOS_ARM_CORE_CONFIGURATION(_nr)   \
>>>>>> +                     (EXYNOS_ARM_CORE0_CONFIGURATION + (0x80 * (_nr)))
>>>>>> +#define EXYNOS_ARM_CORE_STATUS(_nr)          \
>>>>>> +                     (EXYNOS_ARM_CORE_CONFIGURATION(_nr) + 0x4)
>>>
>>> My patches posted quite a while ago [1] to fix DT CPU topology already
>>> add these, remove S5P_ARM_CORE1* and fix corresponding usage in
>>> hotplug.c and platsmp.c.
>>>
>>> [1] http://thread.gmane.org/gmane.linux.kernel.samsung-soc/29573
>>>
>>> So I think you should rebase on top of them or at least on top of
>>> patches 1 and 2 from that series, as 3 and 4 should be dropped.
>>
>> Patch 2 of your series does not apply on kgene's for-next or
>> linux-next. Are you planning on re-sending this ?
>
> OK, it seems like Kukjin has already applied your v6 series, so let's
> drop my series for now. I'll remove patch 1 from my series and rebase it
> on top of your v6.
Ok, thanks.

Regards,
Abhilash
>
> Best regards,
> Tomasz



More information about the linux-arm-kernel mailing list