[PATCH v6 03/15] irq: gic: support hip04 gic

Christoffer Dall christoffer.dall at linaro.org
Thu May 15 05:08:17 PDT 2014


On 15 May 2014 12:14, Arnd Bergmann <arnd at arndb.de> wrote:
> On Thursday 15 May 2014 10:34:35 Marc Zyngier wrote:
>> > +static inline bool gic_is_standard(struct gic_chip_data *gic)
>>
>> Please loose all of the inlines. The compiler can do this by itself.
>>
>> > +{
>> > +       return (gic->nr_cpu_if == 8);
>> > +}
>> > +
>
> I think it's actually the common style to spell out the 'inline'
> for trivial helpers like this. The compiler doesn't need it, but
> it also doesn't hurt and most people write it.
>
Only in header files, no?

I've been chastised previously for putting this in .c files.

-Christoffer



More information about the linux-arm-kernel mailing list