[PATCH v6 03/15] irq: gic: support hip04 gic

Arnd Bergmann arnd at arndb.de
Thu May 15 04:14:22 PDT 2014


On Thursday 15 May 2014 10:34:35 Marc Zyngier wrote:
> > +static inline bool gic_is_standard(struct gic_chip_data *gic)
> 
> Please loose all of the inlines. The compiler can do this by itself.
> 
> > +{
> > +       return (gic->nr_cpu_if == 8);
> > +}
> > +

I think it's actually the common style to spell out the 'inline'
for trivial helpers like this. The compiler doesn't need it, but
it also doesn't hurt and most people write it.

	Arnd



More information about the linux-arm-kernel mailing list