[RFC PATCH 2/9] dt: deps: dependency based device creation
Alexander Holler
holler at ahsoftware.de
Wed May 14 08:51:36 PDT 2014
Am 14.05.2014 16:05, schrieb Grant Likely:
>> +
>> + if (graph.finished)
>> + return -EINVAL; /* cycle found */
>> +
>> + /* of_init_print_order(); */
>
> If you wrap of_init_print_order with a #ifdef DEBUG/#else/#endif, then
> you don't need to comment out the call to of_init_print_order().
To explain why I didn't use DEBUG here: DEBUG enables a lot of
distracting messages. which is true for CONFIG_DEBUG_DRIVER too.
Therefor I often prefer to use just pr_info("AHO: ..."); with which I
print only stuff I want (and can easily grep for).
And as said, the patches I presented are meant for evaluation. I did
patches without discussing them before in order to avoid endless
discussion which likely never would have found an end and therfor would
have prevented a start. So now you already have some to play and test
with, without anyone had to discuss stuff before. ;)
Regards,
Alexander Holler
More information about the linux-arm-kernel
mailing list