[PATCH v4 1/2] ARM: dts: imx51-eukrea-mbimxsd51-baseboard: Add CAN support
Fabio Estevam
festevam at gmail.com
Tue May 6 13:04:44 PDT 2014
On Tue, May 6, 2014 at 4:32 PM, Alexander Shiyan <shc_work at mail.ru> wrote:
>> + can0: can at 0 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_can>;
>> + compatible = "microchip,mcp2515";
>> + reg = <0>;
>> + clocks = <&clk24M>;
>> + spi-max-frequency = <1000000>;
>
> This should be of course 10000000, or removed completely
> since driver already applies such limitation to the SPI bus.
> I think Shawn can fix this during commit.
Yes, this should be 10MHz.
Thanks for the review.
Eric,
I forgot to Cc you on v4. Besides the 10MHz error above, does it look good?
More information about the linux-arm-kernel
mailing list