[PATCH] of: Check for phys_addr_t overflows in early_init_dt_add_memory_arch

Geert Uytterhoeven geert at linux-m68k.org
Thu Jun 19 00:31:17 PDT 2014

Hi Laura,

On Thu, Jun 19, 2014 at 7:04 AM, Laura Abbott <lauraa at codeaurora.org> wrote:
> The common early_init_dt_add_memory_arch takes the base and size
> of a memory region as u64 types. The function never checks if
> the base and size can actually fit in a phys_addr_t which may
> be smaller than 64-bits. This may result in incorrect memory
> being passed to memblock_add if the memory falls outside the
> range of phys_addr_t. Add range checks for the base and size if
> phys_addr_t is smaller than u64.
> Reported-by: Geert Uytterhoeven <geert at linux-m68k.org>
> Signed-off-by: Laura Abbott <lauraa at codeaurora.org>

Tested-by: Geert Uytterhoeven <geert at linux-m68k.org>

> ---
> Geert, can you drop my other patch and give this a test to see if it fixes
> your bootup problem?

Thanks, works fine!



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

More information about the linux-arm-kernel mailing list