[PATCH V2] ARM: STi: DT: Properly define sti-ethclk & stmmaceth for stih415/6

Lee Jones lee.jones at linaro.org
Tue Jun 17 00:10:37 PDT 2014


> On 06/16/2014 11:23 AM, Peter Griffin wrote:
> >This patch fixes two problems: -
> >
> >1) The device tree isn't currently providing sti-ethclk which is
> >required by the dwmac glue code to correctly configure the ethernet
> >PHY clock speed.
> >
> >This means depending on what the bootloader/jtag has
> >configured this clock to, and what switch/hub the board is plugged
> >into you most likely will NOT successfully negotiate a ethernet link.
> >
> >2) The stmmaceth clock was associated with the wrong clock. It was
> >referencing the PHY clock rather than the interconnect clock which
> >clocks the IP.
> >
> >This patch also brings us closer to not having to boot the upstream
> >kernel with the clk_ignore_unused parameter.
> >
> >Signed-off-by: Peter Griffin <peter.griffin at linaro.org>
> >---
> >  arch/arm/boot/dts/stih415.dtsi           | 8 ++++----
> >  arch/arm/boot/dts/stih416.dtsi           | 8 ++++----
> >  include/dt-bindings/clock/stih415-clks.h | 1 +
> >  include/dt-bindings/clock/stih416-clks.h | 1 +
> >  4 files changed, 10 insertions(+), 8 deletions(-)
> 
> Acked-by: Maxime Coquelin <maxime.coquelin at st.com>
> 
> Thanks for the fix!

Can you apply Maxime and my Acks and send to ARM-SoC (CC'ed), due for
their -fixes branch please?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog



More information about the linux-arm-kernel mailing list