[GIT PULL][for 3.17] pull request for hisilicon soc

Arnd Bergmann arnd at arndb.de
Mon Jul 28 04:35:50 PDT 2014

On Sunday 27 July 2014 09:57:22 Haojian Zhuang wrote:
> On 26 July 2014 23:30, Arnd Bergmann <arnd at arndb.de> wrote:
> > On Friday 25 July 2014 14:01:20 xuwei wrote:
> >
> >> ----------------------------------------------------------------
> >> Haifeng Yan (3):
> >>       ARM: debug: Rename Hi3716 to HI5XHD2
> >
> > This one had me confused for a while, because it seems like
> > you are breaking support for hi3xxx, but instead it's just
> > a different name for the same chip if I see this right.
> >
> > An easier approach would actually be to remove DEBUG_HI3716_UART
> > completely: the setting is exactly the same for
> > HI3716, HI3620 and HIX5HD2, so you can simply keep the name
> > for the oldest chip here and change the help text to reflect
> > which products it works on.
> The physical address of hi3xxx uart is different from x5hd2.
> Since hi3620 & hix5hd2 could be built into one image. If I don't use the
> DEBUG_HIX5HD2_UART to mark, I can't distinguish the right UART
> physical address only by ARCH_HI3xxx or ARCH_HIX5HD2.

Ah, you are right, I misread the source code. I saw that the
virtual address is the same for both but didn't notice that
the physical address is not.

So this patch is ok after all, please just clarify in the changelog
that it is actually the same chip.

> > Finally, it's not clear why you need a new Kconfig symbol. It seems
> > that all code you have is compiled independent of these, except for
> > the dtb files and the DEBUG_LL setting.
> >
> Actually it's nearly same except for headsmp.S.
> Hisilicon guys think that hix5hd2 belongs to another group. They don't
> want to totally share their code base with hi3xxx.

This doesn't seem like a technical reason to me at all. I would
much prefer if you and Xu Wei as maintainers were able to describe
(in the changelog) the underlying technical reasons for decisions
coming from management if it makes sense, or otherwise explain to
them that we don't want those patches upstream if it doesn't make

It's not a show-stopper this way, and I'd still pull the branches
with this, but you should be aware that it does not help your

> > What happened to HiP04 support? I thought that would arrive
> > in time for 3.17.
> >
> I just sent v14 in this week. I already updated gic & mcpm according
> to comments. But I haven't gotten any comments & Ack yet. So I don't
> know whether we could send the pull request of HiP04 in 3.17.

I don't see anything beyond v10 in my email, and that had a few
outstanding comments but otherwise looked almost ready to me.
Can you find out what happened?


More information about the linux-arm-kernel mailing list