[PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting

Tony Lindgren tony at atomide.com
Tue Jul 8 01:29:48 PDT 2014


* Sekhar Nori <nsekhar at ti.com> [140707 21:56]:
> On Monday 07 July 2014 08:40 PM, Felipe Balbi wrote:
> > On Mon, Jul 07, 2014 at 02:40:08PM +0100, Russell King - ARM Linux wrote:
> >> --- a/arch/arm/mm/cache-l2x0.c
> >> +++ b/arch/arm/mm/cache-l2x0.c
> >> @@ -732,7 +732,7 @@ static int l2c310_cpu_enable_flz(struct notifier_block *nb, unsigned long act, v
> >>  
> >>  static void __init l2c310_enable(void __iomem *base, u32 aux, unsigned num_lock)
> >>  {
> >> -	unsigned rev = readl_relaxed(base + L2X0_CACHE_ID) & L2X0_CACHE_ID_PART_MASK;
> >> +	unsigned rev = readl_relaxed(base + L2X0_CACHE_ID) & L2X0_CACHE_ID_RTL_MASK;
> >>  	bool cortex_a9 = read_cpuid_part() == ARM_CPU_PART_CORTEX_A9;
> > 
> > even with this change, l2c still tries to write to power control
> > register, at least on AM437x. Looking a little deeper here, AM437x
> > identifies itself as l2c PL310 r3p3, which should have power control
> > register, but aparentely there's no way to write that register. I'll
> > file a bug to our ROM team, but we will certainly need a way to
> > workaround this inside omap4-common.c
> 
> Looks like we need both my patch as well as Russell's patch. I can
> respin my patch with the pr_info_once() dropped if it helps further
> reduce boot noise.

In that case I'm fine with the original patch in this series. Russell,
got any better ideas?

Regards,

Tony



More information about the linux-arm-kernel mailing list