[PATCH] Fix select-induced Kconfig warning for ZBOOT_ROM

Thierry Reding thierry.reding at gmail.com
Mon Jan 13 10:20:12 EST 2014


On Mon, Jan 13, 2014 at 01:48:13PM +0000, Russell King - ARM Linux wrote:
> On Mon, Jan 13, 2014 at 12:52:10PM +0100, Thierry Reding wrote:
> > On Wed, Jan 08, 2014 at 09:20:10AM +0100, Arnd Bergmann wrote:
> > > --- a/arch/arm/mach-imx/Kconfig
> > > +++ b/arch/arm/mach-imx/Kconfig
> > > @@ -3,7 +3,7 @@ config ARCH_MXC
> > >         select ARCH_REQUIRE_GPIOLIB
> > >         select ARM_CPU_SUSPEND if PM
> > >         select ARM_PATCH_PHYS_VIRT
> > > -       select AUTO_ZRELADDR if !ZBOOT_ROM
> > > +       select AUTO_ZRELADDR
> > >         select CLKSRC_MMIO
> > >         select COMMON_CLK
> > >         select GENERIC_ALLOCATOR
> > 
> > Hi Arnd,
> > 
> > I haven't seen this go into linux-next yet. Do you plan on sending a
> > patch for this?
> 
> Maybe someone should respond to this comment from Arnd:
> 
> | On second thought, we should just remove the 'select AUTO_ZRELADDR' from
> | ARCH_MXC and everything that is multiplatform enabled, since it's already
> | selected by ARCH_MULTIPLATFORM.
> 
> which I think is the right way to go here.  The ARCH_MXC option is
> hidden when multiplatform is not enabled.  When it is enabled,
> AUTO_ZRELADDR is selected by the multiplatform option.  So having a
> "select AUTO_ZRELADDR" of any kind under ARCH_MXC is entirely
> redundant.

It looks like ARCH_MXC is the only one that matches Arnd's requirements.
All other platforms that select AUTO_ZRELADDR seem to not support multi-
platform.

Below is a patch to remove the line completely. Shall I post that to the
patch tracker?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ARM-Remove-redundant-select-AUTO_ZRELADDR.patch
Type: text/x-diff
Size: 1302 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140113/82d5820b/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140113/82d5820b/attachment-0001.sig>


More information about the linux-arm-kernel mailing list