[PATCH] Fix select-induced Kconfig warning for ZBOOT_ROM

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Jan 13 08:48:13 EST 2014


On Mon, Jan 13, 2014 at 12:52:10PM +0100, Thierry Reding wrote:
> On Wed, Jan 08, 2014 at 09:20:10AM +0100, Arnd Bergmann wrote:
> > --- a/arch/arm/mach-imx/Kconfig
> > +++ b/arch/arm/mach-imx/Kconfig
> > @@ -3,7 +3,7 @@ config ARCH_MXC
> >         select ARCH_REQUIRE_GPIOLIB
> >         select ARM_CPU_SUSPEND if PM
> >         select ARM_PATCH_PHYS_VIRT
> > -       select AUTO_ZRELADDR if !ZBOOT_ROM
> > +       select AUTO_ZRELADDR
> >         select CLKSRC_MMIO
> >         select COMMON_CLK
> >         select GENERIC_ALLOCATOR
> 
> Hi Arnd,
> 
> I haven't seen this go into linux-next yet. Do you plan on sending a
> patch for this?

Maybe someone should respond to this comment from Arnd:

| On second thought, we should just remove the 'select AUTO_ZRELADDR' from
| ARCH_MXC and everything that is multiplatform enabled, since it's already
| selected by ARCH_MULTIPLATFORM.

which I think is the right way to go here.  The ARCH_MXC option is
hidden when multiplatform is not enabled.  When it is enabled,
AUTO_ZRELADDR is selected by the multiplatform option.  So having a
"select AUTO_ZRELADDR" of any kind under ARCH_MXC is entirely
redundant.

-- 
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".



More information about the linux-arm-kernel mailing list