[PATCH v6 07/14] ARM: Remove use of struct kprobe from generic probes code
Russell King - ARM Linux
linux at arm.linux.org.uk
Fri Feb 28 05:12:26 EST 2014
On Mon, Feb 10, 2014 at 02:38:58AM -0500, David Long wrote:
> diff --git a/arch/arm/kernel/probes.c b/arch/arm/kernel/probes.c
> index 7cd1763..179deac 100644
> --- a/arch/arm/kernel/probes.c
> +++ b/arch/arm/kernel/probes.c
> @@ -12,11 +12,9 @@
> */
>
> #include <linux/kernel.h>
> -#include <linux/kprobes.h>
> #include <asm/system_info.h>
How well has this code been tested? This file doesn't even build because
(I suspect) the above change:
arch/arm/kernel/probes.c: In function 'test_alu_write_pc_interworking':
arch/arm/kernel/probes.c:68:2: error: implicit declaration of function 'BUG_ON' [-Werror=implicit-function-declaration]
make[2]: *** [arch/arm/kernel/probes.o] Error 1
This is because linux/kprobes.h includes linux/bug.h, which would provide
the requirements for BUG_ON().
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
More information about the linux-arm-kernel
mailing list