[PATCH RFC v1 3/3] ARM hibernation / suspend-to-disk
Sebastian Capella
sebastian.capella at linaro.org
Wed Feb 26 12:50:55 EST 2014
Quoting Lorenzo Pieralisi (2014-02-26 02:24:27)
> On Tue, Feb 25, 2014 at 05:55:31PM +0000, Sebastian Capella wrote:
>
> Please add:
>
> "swsusp_save() is executed in the suspend finisher so that the CPU context
> pointer and memory are part of the saved image, which is required by the
> resume kernel image to restart execution from swsusp_arch_suspend()"
>
> > * soft_restart is not technically needed, but is used
> > * to get success returned from cpu_suspend.
> > * After resume, the hibernation snapshot is written out.
>
> "When soft reboot completes, the hibernation snapshot is written out."
>
> Resume is confusing since this code is resuming twice :D on image saving
> and on kernel image restoration.
Thanks Lorenzo!
Here's what I've got.
/*
* Snapshot kernel memory and reset the system.
*
* swsusp_save() is executed in the suspend finisher so that the CPU
* context pointer and memory are part of the saved image, which is
* required by the resume kernel image to restart execution from
* swsusp_arch_suspend().
*
* soft_restart is not technically needed, but is used to get success
* returned from cpu_suspend.
*
* When soft reboot completes, the hibernation snapshot is
* written out.
*/
Does this look ok? I'll prepare a v4 patchset.
Thanks!
Sebastian
More information about the linux-arm-kernel
mailing list