[Patch v7 2/2] dmaengine: add Qualcomm BAM dma driver
Andy Gross
agross at codeaurora.org
Wed Feb 26 12:06:56 EST 2014
On Wed, Feb 26, 2014 at 06:51:55PM +0200, Stanimir Varbanov wrote:
> > + /* read revision and configuration information */
> > + val = readl_relaxed(bdev->regs + BAM_REVISION) & NUM_EES_MASK;
> > +
>
> The ees shit is not zero and you got wrong ee. Could you add the line
> below or something similar:
>
> val = (val >> NUM_EES_SHIFT) & NUM_EES_MASK;
>
Good catch. I missed the shift when I reworked and got lucky that the revision
is in the lower 8 bits and is non-zero.
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
More information about the linux-arm-kernel
mailing list