[PATCH] backlight: add PWM dependencies
thierry.reding at gmail.com
Wed Feb 26 08:25:30 EST 2014
On Mon, Feb 10, 2014 at 12:09:29PM +0100, Linus Walleij wrote:
> On Mon, Feb 10, 2014 at 11:40 AM, Thierry Reding
> <thierry.reding at gmail.com> wrote:
> > it seems like at least BACKLIGHT_LP8788 is missing a corresponding
> > dependency as well.
> > I have applied Sascha's patch to remove the obsolete HAVE_PWM symbol,
> > and this will fix at least the build issues. However it will also cause
> > the driver to fail at runtime because the pwm_*() functions won't work.
> So it definately needs that API, not just stubs.
> But isn't it proper for Kconfig to allow you to break things
> like that by configuring out stuff and have stubs come in?
> I'm a bit torn here.
After thinking about this some more, I've come to the conclusion that
the drivers should have the dependency. Kconfig should make sure that
the resulting drivers work.
If somebody wanted to knowingly build this driver with a configuration
that won't work at runtime, then they should be using COMPILE_TEST
So I'm leaning towards applying this patch if there are no objections.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 836 bytes
Desc: not available
More information about the linux-arm-kernel