[PATCH] mmc: sdhci-bcm-kona: fix build errors when built-in

Russell King rmk+kernel at arm.linux.org.uk
Wed Feb 26 06:42:13 EST 2014


`sdhci_bcm_kona_remove' referenced in section `.data' of drivers/built-in.o: defined in discarded section `.exit.text' of drivers/built-in.o

Fixes: 058feb53666f ("mmc: sdhci-bcm-kona: make linker-section warning go away")
Cc: Markus Mayer <markus.mayer at linaro.org>
Cc: Christian Daudt <csd at broadcom.com>
Cc: Matt Porter <matt.porter at linaro.org>
Cc: <stable at vger.kernel.org>
Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
---
Spotted in nightly build testing, this really should not have happened.
The commit which caused it does more damage than good by changing more
than it should have to fix the warning it reports to have fixed, by
turning it into a build error instead.  Please be more careful in
future when making such changes to fully understand what the section
mismatch errors mean and more importantly, exactly what they're referring
to.  Thanks.

 drivers/mmc/host/sdhci-bcm-kona.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
index 20096aaf14b4..e05c39e6292f 100644
--- a/drivers/mmc/host/sdhci-bcm-kona.c
+++ b/drivers/mmc/host/sdhci-bcm-kona.c
@@ -318,7 +318,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
 	return ret;
 }
 
-static int __exit sdhci_bcm_kona_remove(struct platform_device *pdev)
+static int sdhci_bcm_kona_remove(struct platform_device *pdev)
 {
 	return sdhci_pltfm_unregister(pdev);
 }
-- 
1.8.3.1




More information about the linux-arm-kernel mailing list